HairHeel

Add “play Zelda” to your todo list

Yup. Nothing wrong with pushing up a draft PR and asking for feedback; but definitely need to be an active participant in fixing the issues, not just expect somebody else to do your work for you.

That does lead to some sticky inter-personal situations though. Like there's people on my team that I trust enough to just rubber-stamp a PR that looks good but doesn't have test coverage etc. Can generally trust those people will let me know if the failing tests uncover some substantial work that needs to be re-reviewed.

There's other people I don't trust and will insist their build passes before I review it. Once that person notices they're being held to a different standard, it can be difficult (but necessary) to have a conversation about what they need to change in order to earn that trust.

breaks tests

leaves me to fix them during approval

I’m sorry, what? If he broke it, he fixes it. There should be guard rails that prevent him from merging his code until all the tests pass, and you as a reviewer should refuse to even start a code review unless the build is green.

Who says you have to drop it? I've got stuff from 2007 in there somewhere.

You get two options.

Normally it’s a squashed commit of everything in a feature, with a commit message like:

[JIRA-1234] - Descriptive but Concise Name of Feature

But every now and then it’s multiple commits like:

quick fix
Ugh, fix typo
fuck fuck why doesn’t it work
Oh, I’m stupid

Definitely a lot of greens visible from that angle as well. Easy to see how it got confused, but a great reminder that these things aren’t ready to do it all for you without supervision just yet.

• Installs antivirus on servers that wrecks application performance
• installs content filtering proxy that prevents developers from reading “hacking materials” like OWASP documentation
• won’t let developers install anything on their own machines without filing a ticket and waiting 6 weeks
• pushes unannounced antivirus updates that pop up OS security dialogs like “Netscan Antivirus would like to monitor all network traffic. Enter your password to approve”, and is surprised when users don’t enter their passwords.

Your corporate IT guy

The BBC is also letting Unilever’s Russian employees be conscripted.

Y’all gonna regret this when Ron DeSantis gets put in charge of deciding which information is false enough to be deleted.

Hmm, does lemmy have username filters?

Here’s how I do it.

If somebody more senior than you tells you to do a thing a certain way and you don’t understand why they think their way is better, ask them to explain it, but do it in a polite way. Asking the question shows you’re engaged in the process and not afraid to share your own input.

If you hear the explanation and still disagree, let it go and do it their way. Even if they’re wrong, they won’t want to hear about it from you at that point. You win some, you lose some. Being able to disagree and commit is huge.