Apple

In your shortcut make sure after the screenshot action that there’s another action that saves it to your photos.

If this is already the case I’m not sure what the problem would be.

Best use for the action button imo is the camera so you can open it in no time to take a quick photo or video

For the screenshot you can use the normal method or double tap on the back also a good option