this post was submitted on 09 Dec 2023
1098 points (97.5% liked)

Programmer Humor

25726 readers
1225 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[–] GBU_28@lemm.ee 69 points 2 years ago (4 children)

No closing semicolon, anyone got any extras to throw on this thing?

[–] Moops@lemmy.world 15 points 2 years ago* (last edited 2 years ago) (2 children)

At the very least I'd try to clean up that fuzzy condition on behavior to anticipate any bad or inconsistent data entry.

WHERE UPPER(TRIM(behavior)) = 'NICE'

Depending on the possible values in behavior, adding a wildcard or two might be useful but would need to know more about that field to be certain. Personally I'd rather see if there was a methodology using code values or existing indicators instead of a string, but that's often just wishful thinking.

Edit: Also, why dafuq we doing a select all? What is this, intro to compsci? List out the values you need, ya heathen ;)

(This is my favorite Xmas meme lol)

[–] mp04610@lemm.ee 12 points 2 years ago

behavior is an ENUM.

[–] moroni@lemmy.ca 3 points 2 years ago

That’s a table scan, right there. Naughty.

[–] pruwybn@discuss.tchncs.de 7 points 2 years ago* (last edited 2 years ago)

Need to normalize the database. I would add a join to a BehaviorTypes table.

Edit: or, if the only options are naughty or nice, make it a boolean.

[–] takeda@lemmy.world 4 points 2 years ago (1 children)

You need semicolons if it is a script with multiple commands to separate them. It is not needed for a single statement, like you would use in most language libraries.

[–] mellejwz@lemmy.world 2 points 2 years ago (1 children)

If you don't use a semicolon directly in MySQL it won't do anything until you add it.

[–] takeda@lemmy.world 2 points 2 years ago

In the MySQL client console where you can run multiple commands.

If you add semicolon in language library commands such as fetch() you will get an error.

[–] fmstrat@lemmy.nowsci.com 2 points 2 years ago

Can we get a SIMILARITY?