I've run into this bug too. It happens when I expand an image (click it) but doesn't load quickly and then I click another. If the second image loads before the first, when the first arrives it'll replace the second one.

Clearly a download event race condition.

It's been a small bug that I've been meaning to report and fix myself. I can grab the code, setup development, and get more details (or write a test) if you cannot reproduce.

v1.68.0 (277)

[–] idunnololz@lemmy.world 9 points 1 week ago (2 children)

Oh, I added some fixed in v1.69.0. The release should be out now. I would be curious if the issue still occurs after that update.

[–] pc486@sh.itjust.works 3 points 1 week ago

I've updated to v1.68.2. I'll follow up if I can reproduce the race condition again but I suspect you squashed obvious presentations of it. In commit 8a50165, the change to ImageViewerActivity.kt and LinkFetcher.kt makes reasonable sense to me for my bug. A singleton downloader in a threaded environment presents several kinds of foot-guns. Wrapping the return into a promise certainly sidesteps some data races.

[–] tenchiken@lemmy.dbzer0.com 2 points 1 week ago (1 children)

I believe I got this on the 1.69.1 build just now. It corrected after just a moment, but it was while I was scrolling quickly, maybe 1 to 2 posts per second. Skimming headlines and all of a sudden a news post with a mildly nsfw image quickly changing to generic stock footage after 2 or 3 seconds. The reused image i recall seeing shortly before I think?

I'll try to see if I can force it by quick skimming again or if that is irrelevant to the issue.

[–] tenchiken@lemmy.dbzer0.com 3 points 1 week ago* (last edited 1 week ago) (2 children)

Caught it while scrolling all! Not really scrolling fast but there's another common variable... It was for a video clip.

See the "before tapping" in attached.

It changed to the correct thumbnail once tapped and backed from. See mildly edited next:

Not sure it'll help but that post seems to be here:

(Obviously not safe for work)

https://lemmynsfw.com/post/28850749

Last I confirmed version:

Edit: scrolling back just a few items yielded the original image too I think:

That's for https://lemmy.bestiver.se/post/535254

Edit 2: holy cow... Ummm...

So I had scrolled back up to find the image and after editing here, continued scrolling down (4 posts down by the way!) and this is what I see on that nsfw post preview now:

Worth noting that that image now in that place is from not far back also. 5 posts previous (1 before the first source image).

Also, once hitting save to this edit, the preview was back to the correct NSFW thumbnail.

I hope this helps track down the glitch!

Found another issue maybe... Attempting to post the comment after it has been saved as draft and there's no way to post, only save? I had to come back to post directly after copy/paste.

[–] idunnololz@lemmy.world 2 points 1 week ago

Thank you for the detailed report. I made a release last night but it's being reviewed by Google at the moment. I will comment again once its available so you can test it. However, that update was just me blindly fixing things so no guarantees it will fix the bug youve reported.

I will look at the code again tonight since i have a better idea of where to look now.

[–] tenchiken@lemmy.dbzer0.com 1 points 1 week ago

The issue seems to manifest most frequently on posts from lemmynsfw for me when I'm scrolling under all.

[–] phonics@lemmy.world 2 points 1 week ago (1 children)

I'm on android 12

[–] idunnololz@lemmy.world 4 points 1 week ago* (last edited 1 week ago) (1 children)

Can you check which version of the app you are on? You can see it in Settings > About Summit.

[–] phonics@lemmy.world 5 points 1 week ago (1 children)

1.68.0 277

[–] idunnololz@lemmy.world 2 points 1 week ago (1 children)

Thank you.

[–] phonics@lemmy.world 2 points 1 week ago

No problem. Happens maybe once a day or every 2 days. And I guess I'm on Lemmy for like 2 hours a day on average