One problem is GHs auto-merge when ready button. It will merge when there are still tests running unless they are required. It would be much better if the auto merges took into account all checks and not just required ones.

[–] voytrekk@sopuli.xyz 12 points 1 week ago (5 children)

It tests passing is a requirement of merging, then you should set the tests as required.

[–] nous@programming.dev 2 points 1 week ago (3 children)

If you have folderA and folderB each with their own set of tests. You don't need folderAs tests to run with a change to folderB. Most CI/CD systems can do this easily enough with two different reports. But you cannot mark them both as required as they both wont always run. Instead you need a complicated fan out pipelines in your CICD system so you can only have one report back to GH or you need to always spawn a job for both folders and have the ones that dont need to run return successful. Neither of these is very good and becomes very complex when you are working with large monorepos.

It would be much better if the CICD system that knows which pipelines it needs to run for a given PR could tell GH about which tests are required for a particular PR and if you could configure GH to wait for that report from the CICD system. Or at the very least if the auto-merge was blocked for any failed checks and the manual merge button was only blocked on required checks.

[–] BatmanAoD@programming.dev 2 points 1 week ago

Both GitHub Actions and GitLab CI let you specify filepath rules for triggering jobs.

load more comments (2 replies)

load more comments (3 replies)