this post was submitted on 28 Jul 2023
33 points (97.1% liked)

Rust

7280 readers
3 users here now

Welcome to the Rust community! This is a place to discuss about the Rust programming language.

Wormhole

!performance@programming.dev

Credits

  • The icon is a modified version of the official rust logo (changing the colors to a gradient and black background)

founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[โ€“] Anders429@lemmy.world 12 points 2 years ago (2 children)

We need clearer rules on which pull requests require code reviews.

Weird to me that any pull request would not require a code review.

[โ€“] CoderKat@lemm.ee 2 points 2 years ago* (last edited 2 years ago)

Yeah. At my current and previous jobs, literally everything going into an actual product required a code review, and that's despite all the code being written by employees that you could generally trust. Even if my boss or literally the most experienced and trusted dev wrote a commit, it still needed a review.

It's feels weird submitting my own code without a review for side projects. So many bugs have been caught by reviewers that writing code that another person would use without it being reviewed feels just wrong.

load more comments (1 replies)